fix: define items.type for k8srequiredlabels (#1955)

Signed-off-by: GitHub <noreply@github.com> Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
open-policy-agent · Apr 1, 2022 · 08cef07 · 08cef07
1 parent 40e5c86
commit 08cef07
Show file tree

Hide file tree

Showing 7 changed files with 17 additions and 10 deletions.
diff --git a/demo/basic/templates/k8srequiredlabels_template.yaml b/demo/basic/templates/k8srequiredlabels_template.yaml
@@ -14,7 +14,8 @@ spec:
           properties:
             labels:
               type: array
-              items: string
+              items:
+                type: string
   targets:
     - target: admission.k8s.gatekeeper.sh
       rego: |

diff --git a/demo/basic/templates/k8srequiredlabels_template_external_data.yaml b/demo/basic/templates/k8srequiredlabels_template_external_data.yaml
@@ -14,7 +14,8 @@ spec:
           properties:
             labels:
               type: array
-              items: string
+              items:
+                type: string
   targets:
     - target: admission.k8s.gatekeeper.sh
       rego: |

diff --git a/pkg/readiness/testdata/99-k8srequiredlabels_template.yaml b/pkg/readiness/testdata/99-k8srequiredlabels_template.yaml
@@ -13,7 +13,8 @@ spec:
           properties:
             labels:
               type: array
-              items: string
+              items:
+                type: string
   targets:
     - target: admission.k8s.gatekeeper.sh
       rego: |

diff --git a/test/bats/tests/templates/k8srequiredlabels_template.yaml b/test/bats/tests/templates/k8srequiredlabels_template.yaml
@@ -15,7 +15,8 @@ spec:
           properties:
             labels:
               type: array
-              items: string
+              items:
+                type: string
   targets:
     - target: admission.k8s.gatekeeper.sh
       rego: |

diff --git a/website/docs/howto.md b/website/docs/howto.md
@@ -28,7 +28,8 @@ spec:
           properties:
             labels:
               type: array
-              items: string
+              items:
+                type: string
   targets:
     - target: admission.k8s.gatekeeper.sh
       rego: |
@@ -127,7 +128,7 @@ The K8sRequiredLabels "ns-must-have-gk" is invalid: spec.parameters: Invalid val
 
 ### The enforcementAction field
 
-The `enforcementAction` field defines the action for handling Constraint violations. By default, `enforcementAction` is set to `deny` as the default behavior is to deny admission requests with any violation. Other supported enforcementActions include `dryrun` and `warn`. Refer to [Handling Constraint Violations](violations.md) for more details. 
+The `enforcementAction` field defines the action for handling Constraint violations. By default, `enforcementAction` is set to `deny` as the default behavior is to deny admission requests with any violation. Other supported enforcementActions include `dryrun` and `warn`. Refer to [Handling Constraint Violations](violations.md) for more details.
 
 ### Listing constraints
 You can list all constraints in a cluster with the following command:

diff --git a/website/versioned_docs/version-v3.6.x/howto.md b/website/versioned_docs/version-v3.6.x/howto.md
@@ -28,7 +28,8 @@ spec:
           properties:
             labels:
               type: array
-              items: string
+              items:
+                type: string
   targets:
     - target: admission.k8s.gatekeeper.sh
       rego: |
@@ -128,7 +129,7 @@ The K8sRequiredLabels "ns-must-have-gk" is invalid: spec.parameters: Invalid val
 
 ### The enforcementAction field
 
-The `enforcementAction` field defines the action for handling Constraint violations. By default, `enforcementAction` is set to `deny` as the default behavior is to deny admission requests with any violation. Other supported enforcementActions include `dryrun` and `warn`. Refer to [Handling Constraint Violations](violations.md) for more details. 
+The `enforcementAction` field defines the action for handling Constraint violations. By default, `enforcementAction` is set to `deny` as the default behavior is to deny admission requests with any violation. Other supported enforcementActions include `dryrun` and `warn`. Refer to [Handling Constraint Violations](violations.md) for more details.
 
 ### Listing constraints
 You can list all constraints in a cluster with the following command:

diff --git a/website/versioned_docs/version-v3.7.x/howto.md b/website/versioned_docs/version-v3.7.x/howto.md
@@ -28,7 +28,8 @@ spec:
           properties:
             labels:
               type: array
-              items: string
+              items:
+                type: string
   targets:
     - target: admission.k8s.gatekeeper.sh
       rego: |
@@ -128,7 +129,7 @@ The K8sRequiredLabels "ns-must-have-gk" is invalid: spec.parameters: Invalid val
 
 ### The enforcementAction field
 
-The `enforcementAction` field defines the action for handling Constraint violations. By default, `enforcementAction` is set to `deny` as the default behavior is to deny admission requests with any violation. Other supported enforcementActions include `dryrun` and `warn`. Refer to [Handling Constraint Violations](violations.md) for more details. 
+The `enforcementAction` field defines the action for handling Constraint violations. By default, `enforcementAction` is set to `deny` as the default behavior is to deny admission requests with any violation. Other supported enforcementActions include `dryrun` and `warn`. Refer to [Handling Constraint Violations](violations.md) for more details.
 
 ### Listing constraints
 You can list all constraints in a cluster with the following command: