Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syncannotationreader.go uses incorrect annotation key #2820

Closed
julianKatz opened this issue Jun 8, 2023 · 1 comment
Closed

syncannotationreader.go uses incorrect annotation key #2820

julianKatz opened this issue Jun 8, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@julianKatz
Copy link
Contributor

julianKatz commented Jun 8, 2023 •
edited

gatekeeper/pkg/syncutil/parser/syncannotationreader.go

Line 13 in cac4f35

const SyncAnnotationName = "metadata.gatekeeper.sh/requires-sync-data"

syncannotationreader.go has the SyncAnnotationName as "metadata.gatekeeper.sh/requires-sync-data".

The actual key (example) is camelcase:

    metadata.gatekeeper.sh/requiresSyncData: |

Plz fix :)
@julianKatz julianKatz added the bug Something isn't working label Jun 8, 2023
julianKatz added a commit to julianKatz/gatekeeper that referenced this issue Jun 8, 2023
@julianKatz
fix: make sync data annotation camelCase
0374f44 
Fixes open-policy-agent#2820

Signed-off-by: juliankatz <juliankatz@google.com>
@julianKatz julianKatz mentioned this issue Jun 8, 2023
Closed
julianKatz added a commit to julianKatz/gatekeeper that referenced this issue Jun 8, 2023
@julianKatz
fix: make sync data annotation camelCase
b7baafa 
Fixes open-policy-agent#2820

Signed-off-by: juliankatz <juliankatz@google.com>
@julianKatz
Copy link
Contributor Author

This different annotation was agreed upon in #2734 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make sync data annotation camelCase julianKatz/gatekeeper
1 participant
@julianKatz