Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Helm README #1032

Merged

Conversation

carloscastrojumo
Copy link
Contributor

What this PR does / why we need it:
Number of replicas of Gatekeeper in the Helm chart README does not match what is defined in values.yaml (3 replicas).

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Update documentation for consistency.

Special notes for your reviewer:

Signed-off-by: Carlos Castro <carlos.castro@jumo.world>
@maxsmythe
Copy link
Contributor

Thanks for the contribution!

Could you update this file instead:

https://github.com/open-policy-agent/gatekeeper/blob/master/cmd/build/helmify/static/README.md

charts/gatekeeper/README.md gets clobbered by the above file every time we cut a release.

Signed-off-by: Carlos Castro <carlos.castro@jumo.world>
@carloscastrojumo
Copy link
Contributor Author

Thanks for the contribution!

Could you update this file instead:

https://github.com/open-policy-agent/gatekeeper/blob/master/cmd/build/helmify/static/README.md

charts/gatekeeper/README.md gets clobbered by the above file every time we cut a release.

Oops, should have read the contributing changes part at the end of the file. Done.

@ritazh
Copy link
Member

ritazh commented Dec 21, 2020

Thanks for the PR @carloscastrojumo! Can you please rebase and resolve the conflicts? Thanks!

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending rebase

@sozercan sozercan merged commit 9917db6 into open-policy-agent:master Mar 3, 2021
@sozercan sozercan mentioned this pull request Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants