Upgrade to controller-runtime v0.7.0 #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
sozercan
commented
Jan 20, 2021
Codecov Report
@@ Coverage Diff @@
## master #1073 +/- ##
==========================================
+ Coverage 48.08% 48.12% +0.04%
==========================================
Files 62 62
Lines 4274 4264 -10
==========================================
- Hits 2055 2052 -3
+ Misses 1964 1959 -5
+ Partials 255 253 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
sozercan
commented
Jan 20, 2021
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
maxsmythe
reviewed
Jan 21, 2021
|
Thanks @sozercan, @maxsmythe! I'm reviewing this PR today. |
shomron
reviewed
Jan 21, 2021
pkg/controller/constrainttemplatestatus/constrainttemplatestatus_controller.go
Outdated
Show resolved
Hide resolved
shomron
reviewed
Jan 21, 2021
third_party/sigs.k8s.io/controller-runtime/pkg/dynamiccache/internal/deleg_map.go
Show resolved
Hide resolved
shomron
reviewed
Jan 21, 2021
third_party/sigs.k8s.io/controller-runtime/pkg/dynamiccache/internal/informers_map.go
Outdated
Show resolved
Hide resolved
|
nit: looks like the comment in |
|
@sozercan done reviewing - there are a few small blockers to address but overall you did a fantastic job on this! |
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
shomron
reviewed
Jan 26, 2021
pkg/controller/constrainttemplate/constrainttemplate_controller_test.go
Outdated
Show resolved
Hide resolved
shomron
reviewed
Jan 26, 2021
shomron
reviewed
Jan 26, 2021
third_party/sigs.k8s.io/controller-runtime/pkg/dynamiccache/cache.go
Outdated
Show resolved
Hide resolved
maxsmythe
approved these changes
Jan 27, 2021
third_party/sigs.k8s.io/controller-runtime/pkg/dynamiccache/cache_suite_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sertac Ozercan sozercan@gmail.com
What this PR does / why we need it:
Upgrades controller-runtime to v0.7.0 - https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.7.0
Required PRs:
open-policy-agent/cert-controller#18
open-policy-agent/frameworks#106
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: