added hostNetwork option for controllerManager and Audit helm templates #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nandan Sadineni <snvnandan@gmail.com>
Signed-off-by: Nandan Sadineni <snvnandan@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1098 +/- ##
==========================================
+ Coverage 48.05% 48.08% +0.02%
==========================================
Files 62 62
Lines 4274 4274
==========================================
+ Hits 2054 2055 +1
Misses 1964 1964
+ Partials 256 255 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@ritazh can I get a review on this, please? |
ritazh
approved these changes
Jan 28, 2021
|
Hello ! What version is this available this feature/fix in? |
|
It doesn't look like this has been released as-of-yet. @ritazh time to cut a new release? |
|
Sure. Tagging this for release v3.3.1. We can discuss when to cut it during the community call. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nandan Sadineni snvnandan@gmail.com
What this PR does / why we need it:
This enables adding
hostNetworkoption forcontrollerManagerandauditdeployments in helm charts. This is needed for deployments where pod and control plane networks are different. This enhancement will enable deploying those pods in the underlying host network enabling communication between pod and control plane.Which issue(s) this PR fixes:
Fixes #1091