Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified Helm CRD's cleanup procedure #1246

Merged
merged 3 commits into from
Apr 14, 2021
Merged

Simplified Helm CRD's cleanup procedure #1246

merged 3 commits into from
Apr 14, 2021

Conversation

pentago
Copy link
Contributor

@pentago pentago commented Apr 13, 2021

Provides better and less error-prone cleanup procedure.

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxsmythe
Copy link
Contributor

maxsmythe commented Apr 13, 2021

@pentago can you fix the DCO check?

https://github.com/open-policy-agent/gatekeeper/pull/1246/checks?check_run_id=2335955288

@maxsmythe maxsmythe merged commit 4cbf8bd into open-policy-agent:master Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants