-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add priority class name #1266
Add priority class name #1266
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1266 +/- ##
==========================================
+ Coverage 49.77% 49.86% +0.08%
==========================================
Files 65 65
Lines 4522 4522
==========================================
+ Hits 2251 2255 +4
+ Misses 1957 1956 -1
+ Partials 314 311 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Chris Stanaway <chris.stanaway@here.com>
Signed-off-by: Chris Stanaway <chris.stanaway@here.com>
…chart README to reference `kustomize-for-helm.yaml`. Signed-off-by: Chris Stanaway <chris.stanaway@here.com>
8699a38
to
d4be99d
Compare
I signed it |
Signed-off-by: Chris Stanaway <chris.stanaway@here.com>
d92c995
to
0996b18
Compare
Signed-off-by: Chris Stanaway <chris.stanaway@here.com>
Signed-off-by: Chris Stanaway <chris.stanaway@here.com>
Signed-off-by: Chris Stanaway <chris.stanaway@here.com>
manifest_staging/charts/gatekeeper/templates/gatekeeper-audit-deployment.yaml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@maxsmythe @shomron @ritazh LGTY? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add support for priorityClassName (open-policy-agent#1252) Signed-off-by: Chris Stanaway <chris.stanaway@here.com> * Add support for priorityClassName (open-policy-agent#1252) Signed-off-by: Chris Stanaway <chris.stanaway@here.com> * Removed changes to `charts` directory per instructions. Updated helm chart README to reference `kustomize-for-helm.yaml`. Signed-off-by: Chris Stanaway <chris.stanaway@here.com> * Added priorityClassName to the default deployment Signed-off-by: Chris Stanaway <chris.stanaway@here.com> * Moved README update Signed-off-by: Chris Stanaway <chris.stanaway@here.com> * Add newline at end of file Signed-off-by: Chris Stanaway <chris.stanaway@here.com> * Moved README update Signed-off-by: Chris Stanaway <chris.stanaway@here.com> Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
What this PR does / why we need it:
Sets the
priorityClassName
for the controller-manager and audit deployment templates in the helm chart.Which issue(s) this PR fixes:
Fixes #1252
Special notes for your reviewer:
None