Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add priority class name #1266

Merged
merged 9 commits into from
Apr 28, 2021

Conversation

jcstanaway
Copy link
Contributor

What this PR does / why we need it:

Sets the priorityClassName for the controller-manager and audit deployment templates in the helm chart.

Which issue(s) this PR fixes:

Fixes #1252

Special notes for your reviewer:

None

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2021

Codecov Report

Merging #1266 (fb68d87) into master (d883817) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1266      +/-   ##
==========================================
+ Coverage   49.77%   49.86%   +0.08%     
==========================================
  Files          65       65              
  Lines        4522     4522              
==========================================
+ Hits         2251     2255       +4     
+ Misses       1957     1956       -1     
+ Partials      314      311       -3     
Flag Coverage Δ
unittests 49.86% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onstrainttemplate/constrainttemplate_controller.go 55.66% <0.00%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d883817...fb68d87. Read the comment docs.

Signed-off-by: Chris Stanaway <chris.stanaway@here.com>
Signed-off-by: Chris Stanaway <chris.stanaway@here.com>
…chart README to reference `kustomize-for-helm.yaml`.

Signed-off-by: Chris Stanaway <chris.stanaway@here.com>
@jcstanaway
Copy link
Contributor Author

I signed it

Signed-off-by: Chris Stanaway <chris.stanaway@here.com>
Signed-off-by: Chris Stanaway <chris.stanaway@here.com>
Signed-off-by: Chris Stanaway <chris.stanaway@here.com>
Signed-off-by: Chris Stanaway <chris.stanaway@here.com>
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan sozercan requested a review from a team April 21, 2021 00:58
@sozercan
Copy link
Member

@maxsmythe @shomron @ritazh LGTY?

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritazh ritazh merged commit a974d70 into open-policy-agent:master Apr 28, 2021
julianKatz pushed a commit to julianKatz/gatekeeper that referenced this pull request May 11, 2021
* Add support for priorityClassName (open-policy-agent#1252)

Signed-off-by: Chris Stanaway <chris.stanaway@here.com>

* Add support for priorityClassName (open-policy-agent#1252)

Signed-off-by: Chris Stanaway <chris.stanaway@here.com>

* Removed changes to `charts` directory per instructions. Updated helm chart README to reference `kustomize-for-helm.yaml`.

Signed-off-by: Chris Stanaway <chris.stanaway@here.com>

* Added priorityClassName to the default deployment

Signed-off-by: Chris Stanaway <chris.stanaway@here.com>

* Moved README update

Signed-off-by: Chris Stanaway <chris.stanaway@here.com>

* Add newline at end of file

Signed-off-by: Chris Stanaway <chris.stanaway@here.com>

* Moved README update

Signed-off-by: Chris Stanaway <chris.stanaway@here.com>

Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running with system-cluster-critical priority
5 participants