Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test matrix for k8s versions #1268

Merged
merged 3 commits into from
Apr 29, 2021

Conversation

sozercan
Copy link
Member

Signed-off-by: Sertac Ozercan sozercan@gmail.com

What this PR does / why we need it:
Adds a matrix of supported Kubernetes versions for testing for manifest (Helm is pinned to latest)
Kind does not support v1.21 yet, it can be added once supported

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #1075

Special notes for your reviewer:

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan sozercan requested a review from a team April 21, 2021 16:38
@sozercan sozercan changed the title add matrix for k8s versions add test matrix for k8s versions Apr 21, 2021
@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2021

Codecov Report

Merging #1268 (bbd91d6) into master (fc67ca8) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1268      +/-   ##
==========================================
- Coverage   49.97%   49.93%   -0.05%     
==========================================
  Files          65       65              
  Lines        4522     4522              
==========================================
- Hits         2260     2258       -2     
- Misses       1952     1954       +2     
  Partials      310      310              
Flag Coverage Δ
unittests 49.93% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onstrainttemplate/constrainttemplate_controller.go 56.63% <0.00%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc67ca8...bbd91d6. Read the comment docs.

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan sozercan requested a review from ritazh April 26, 2021 20:59
@sozercan sozercan merged commit aa20de6 into open-policy-agent:master Apr 29, 2021
@sozercan sozercan deleted the e2e-matrix branch April 29, 2021 15:39
julianKatz pushed a commit to julianKatz/gatekeeper that referenced this pull request May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

K8s versions used for e2e
4 participants