Surface template errors #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Tabita <ctab@google.com>
Signed-off-by: Craig Tabita <ctab@google.com>
Signed-off-by: Craig Tabita <ctab@google.com>
Signed-off-by: Craig Tabita <ctab@google.com>
… surface-template-errors
Signed-off-by: Craig Tabita <ctab@google.com>
Signed-off-by: Craig Tabita <ctab@google.com>
Signed-off-by: Craig Tabita <ctab@google.com>
Signed-off-by: Craig Tabita <ctab@google.com>
ctab
force-pushed
the
surface-template-errors
branch
from
e5de30d
to
63d4edc
Compare
…late-errors Signed-off-by: Craig Tabita <ctab@google.com>
ctab
force-pushed
the
surface-template-errors
branch
from
63d4edc
to
9566c59
Compare
Signed-off-by: Craig Tabita <ctab@google.com>
Signed-off-by: Craig Tabita <ctab@google.com>
…into surface-template-errors Signed-off-by: Craig Tabita <ctab@google.com>
Signed-off-by: Craig Tabita <ctab@google.com>
Signed-off-by: Craig Tabita <ctab@google.com>
ctab
force-pushed
the
surface-template-errors
branch
from
d75ae82
to
43d57e2
Compare
Signed-off-by: Craig Tabita <ctab@google.com>
maxsmythe
requested changes
Jun 11, 2019
There was a problem hiding this comment.
Looking good.
The biggest missing piece is that we need some code to remove errors once they no longer apply.
I suggest moving k8s errors for creating a CRD (line 211 in new code) to a known error so that it can be filtered and removed once the CRD is successfully created.
We also need a way of clearing parsing errors once the Rego successfully parses.
pkg/controller/constrainttemplate/constrainttemplate_controller.go
Outdated
Show resolved
Hide resolved
| @@ -180,7 +207,9 @@ func (r *ReconcileConstraintTemplate) handleCreate( | |||
| } | |||
| log.Info("creating constraint CRD") | |||
| if err := r.Create(context.TODO(), crd); err != nil { | |||
| instance.Status.Error = fmt.Sprintf("Could not create CRD: %s", err) | |||
| instance.Status.Errors = []*v1alpha1.CreateCRDError{} | |||
| createErr := &v1alpha1.CreateCRDError{Code: "unknown_error", Message: fmt.Sprintf("Could not create CRD: %s", err), Location: ""} | |||
There was a problem hiding this comment.
This could be a known error
There was a problem hiding this comment.
I've replaced this with "create_error". Just wanted something for any errors that could come back without a code field.
Signed-off-by: Craig Tabita <ctab@google.com>
Signed-off-by: Craig Tabita <ctab@google.com>
ctab
commented
Jun 11, 2019
Signed-off-by: Craig Tabita <ctab@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any errors in reconciling constraint templates caused by e.g. Rego syntax will appear in the status as a list of error objects.