-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for namespaceselector #131
Merged
maxsmythe
merged 2 commits into
open-policy-agent:master
from
ritazh:feat-namespaceselector
Jun 14, 2019
Merged
add support for namespaceselector #131
maxsmythe
merged 2 commits into
open-policy-agent:master
from
ritazh:feat-namespaceselector
Jun 14, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsmythe
requested changes
Jun 12, 2019
demo/agilebank/bad_resources/opa_wrong_repo_namespaceselector.yaml
Outdated
Show resolved
Hide resolved
b2780c2
to
95444d8
Compare
95444d8
to
d4e1cc4
Compare
maxsmythe
requested changes
Jun 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after typo fix.
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
d4e1cc4
to
4dcd489
Compare
maxsmythe
approved these changes
Jun 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
maxsmythe
pushed a commit
that referenced
this pull request
Jun 26, 2019
…en successfully created (#148) * Added documentation detailing how to view logs if a constraint is not successfully being applied Signed-off-by: Jessica de Leeuw <jessicadl@google.com> * Edited documentation detailing incorrect Rego in CTs Signed-off-by: Jessica de Leeuw <jessicadl@google.com> * Fix some URLs to point to raw resources. (#115) Signed-off-by: Brendan Burns <bburns@microsoft.com> Signed-off-by: Jessica de Leeuw <jessicadl@google.com> * update url (#139) Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Jessica de Leeuw <jessicadl@google.com> * Forgot closing quote Signed-off-by: Jessica de Leeuw <jessicadl@google.com> * add support for namespaceselector (#131) * add support for namespaceselector Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com> * add example; update rego Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Jessica de Leeuw <jessicadl@google.com> * Added information about incorrect Rego in CT to debugging section Signed-off-by: Jessica de Leeuw <jessicadl@google.com> * Removed information that should have been taken out with the last commit Signed-off-by: Jessica de Leeuw <jessicadl@google.com> * Edited CT debugging info to include the case where CTs look like they have been created Signed-off-by: Jessica de Leeuw <jessicadl@google.com> * Updated debugging information with command to view build errors in status foeld Signed-off-by: Jessica de Leeuw <jessicadl@google.com>
maxsmythe
pushed a commit
that referenced
this pull request
Jun 27, 2019
* Added documentation detailing how to view logs if a constraint is not successfully being applied Signed-off-by: Jessica de Leeuw <jessicadl@google.com> * Edited documentation detailing incorrect Rego in CTs Signed-off-by: Jessica de Leeuw <jessicadl@google.com> * Fix some URLs to point to raw resources. (#115) Signed-off-by: Brendan Burns <bburns@microsoft.com> Signed-off-by: Jessica de Leeuw <jessicadl@google.com> * update url (#139) Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Jessica de Leeuw <jessicadl@google.com> * Forgot closing quote Signed-off-by: Jessica de Leeuw <jessicadl@google.com> * add support for namespaceselector (#131) * add support for namespaceselector Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com> * add example; update rego Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Jessica de Leeuw <jessicadl@google.com> * Added information about incorrect Rego in CT to debugging section Signed-off-by: Jessica de Leeuw <jessicadl@google.com> * Removed information that should have been taken out with the last commit Signed-off-by: Jessica de Leeuw <jessicadl@google.com> * Edited CT debugging info to include the case where CTs look like they have been created Signed-off-by: Jessica de Leeuw <jessicadl@google.com> * Updated debugging information with command to view build errors in status foeld Signed-off-by: Jessica de Leeuw <jessicadl@google.com> * Updated out of date link to install Kubebuilder with a working URL. Signed-off-by: Jessica de Leeuw <jessicadl@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rita Zhang rita.z.zhang@gmail.com
Fixes #127