Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for namespaceselector #131

Merged
merged 2 commits into from
Jun 14, 2019

Conversation

ritazh
Copy link
Member

@ritazh ritazh commented Jun 12, 2019

Signed-off-by: Rita Zhang rita.z.zhang@gmail.com

Fixes #127

@ritazh ritazh requested a review from maxsmythe June 12, 2019 01:48
README.md Outdated Show resolved Hide resolved
pkg/target/regolib/src.rego Outdated Show resolved Hide resolved
pkg/target/regolib/src.rego Outdated Show resolved Hide resolved
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after typo fix.

README.md Outdated Show resolved Hide resolved
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxsmythe maxsmythe merged commit 3a0411b into open-policy-agent:master Jun 14, 2019
maxsmythe pushed a commit that referenced this pull request Jun 26, 2019
…en successfully created (#148)

* Added documentation detailing how to view logs if a constraint is not successfully being applied

Signed-off-by: Jessica de Leeuw <jessicadl@google.com>

* Edited documentation detailing incorrect Rego in CTs

Signed-off-by: Jessica de Leeuw <jessicadl@google.com>

* Fix some URLs to point to raw resources. (#115)

Signed-off-by: Brendan Burns <bburns@microsoft.com>
Signed-off-by: Jessica de Leeuw <jessicadl@google.com>

* update url (#139)

Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
Signed-off-by: Jessica de Leeuw <jessicadl@google.com>

* Forgot closing quote

Signed-off-by: Jessica de Leeuw <jessicadl@google.com>

* add support for namespaceselector (#131)

* add support for namespaceselector

Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>

* add example; update rego

Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
Signed-off-by: Jessica de Leeuw <jessicadl@google.com>

* Added information about incorrect Rego in CT to debugging section

Signed-off-by: Jessica de Leeuw <jessicadl@google.com>

* Removed information
that should have been taken out with the last commit

Signed-off-by: Jessica de Leeuw <jessicadl@google.com>

* Edited CT debugging info to include the case where CTs look like they have been created

Signed-off-by: Jessica de Leeuw <jessicadl@google.com>

* Updated debugging information with command to view build errors in status foeld

Signed-off-by: Jessica de Leeuw <jessicadl@google.com>
maxsmythe pushed a commit that referenced this pull request Jun 27, 2019
* Added documentation detailing how to view logs if a constraint is not successfully being applied

Signed-off-by: Jessica de Leeuw <jessicadl@google.com>

* Edited documentation detailing incorrect Rego in CTs

Signed-off-by: Jessica de Leeuw <jessicadl@google.com>

* Fix some URLs to point to raw resources. (#115)

Signed-off-by: Brendan Burns <bburns@microsoft.com>
Signed-off-by: Jessica de Leeuw <jessicadl@google.com>

* update url (#139)

Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
Signed-off-by: Jessica de Leeuw <jessicadl@google.com>

* Forgot closing quote

Signed-off-by: Jessica de Leeuw <jessicadl@google.com>

* add support for namespaceselector (#131)

* add support for namespaceselector

Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>

* add example; update rego

Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
Signed-off-by: Jessica de Leeuw <jessicadl@google.com>

* Added information about incorrect Rego in CT to debugging section

Signed-off-by: Jessica de Leeuw <jessicadl@google.com>

* Removed information
that should have been taken out with the last commit

Signed-off-by: Jessica de Leeuw <jessicadl@google.com>

* Edited CT debugging info to include the case where CTs look like they have been created

Signed-off-by: Jessica de Leeuw <jessicadl@google.com>

* Updated debugging information with command to view build errors in status foeld

Signed-off-by: Jessica de Leeuw <jessicadl@google.com>

* Updated out of date link to install Kubebuilder with a working URL.

Signed-off-by: Jessica de Leeuw <jessicadl@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support namespaceSelector for constraints
2 participants