Upgrade constrainttemplate_controller to apiextensionsv1 #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianKatz
force-pushed
the
switch-libraries-to-apiextensionsv1
branch
from
39be7e3
to
874ebcb
Compare
Codecov Report
@@ Coverage Diff @@
## master #1320 +/- ##
===========================================
+ Coverage 48.60% 59.60% +10.99%
===========================================
Files 68 2 -66
Lines 4890 354 -4536
===========================================
- Hits 2377 211 -2166
+ Misses 2162 101 -2061
+ Partials 351 42 -309
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
julianKatz
force-pushed
the
switch-libraries-to-apiextensionsv1
branch
from
874ebcb
to
1e446a6
Compare
|
The e2e tests that are failing here are failing for other PRs as well. |
|
#1321 fixes the e2e. pls rebase |
julianKatz
force-pushed
the
switch-libraries-to-apiextensionsv1
branch
from
cb32f87
to
fde524c
Compare
Done! Thanks for fixing that |
maxsmythe
requested changes
May 24, 2021
pkg/controller/constrainttemplate/constrainttemplate_controller_suite_test.go
Outdated
Show resolved
Hide resolved
julianKatz
force-pushed
the
switch-libraries-to-apiextensionsv1
branch
2 times, most recently
from
72ba0d7
to
52d3d91
Compare
This PR changes constrainttemplate_controller to use apiextensionsv1 to create Constraint kind v1 CRDs. That change revealed some additional problems. In particular, that byPod status was being pruned by the API server. This required a fix in Constraint Framework. open-policy-agent/frameworks#120 adds a status field to the Constraint kind CRD. This allows Gatekeeper to add byPodStatus to the object. This PR imports this new code and updates some tests. Contributes to open-policy-agent#550 Signed-off-by: juliankatz <juliankatz@google.com>
julianKatz
force-pushed
the
switch-libraries-to-apiextensionsv1
branch
from
52d3d91
to
0489c31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes constrainttemplate_controller to use apiextensionsv1 to
create Constraint kind v1 CRDs. That change revealed some additional
problems. In particular, that byPod status was being pruned by the API
server. This required a fix in Constraint Framework.
open-policy-agent/frameworks#120 adds a status field to the Constraint
kind CRD. This allows Gatekeeper to add byPodStatus to the object.
This PR imports this new code and updates some tests.
Contributes to #550
Signed-off-by: juliankatz juliankatz@google.com