Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kind 1.22 Github Workflow #1334

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

julianKatz
Copy link
Contributor

@julianKatz julianKatz commented Jun 1, 2021

This PR adds a separate github workflow for testing k8s 1.22 via a
custom-built k8s 1.22 node image. 1.22 isn't currently available under
kindest/node on docker hub, as 1.22 hasn't been officially released.

sozercan built and pushed this image from the k8s GitHub repo. Once k8s
1.22 is available via the typical kindest/node pathway, the changes in
this PR should be removed.

Signed-off-by: juliankatz juliankatz@google.com

@julianKatz julianKatz marked this pull request as draft June 1, 2021 19:30
@codecov-commenter
Copy link

Codecov Report

Merging #1334 (761139c) into master (e229247) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1334      +/-   ##
==========================================
- Coverage   48.38%   48.32%   -0.07%     
==========================================
  Files          68       68              
  Lines        4913     4913              
==========================================
- Hits         2377     2374       -3     
- Misses       2183     2186       +3     
  Partials      353      353              
Flag Coverage Δ
unittests 48.32% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/readiness/object_tracker.go 80.97% <0.00%> (-1.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e016a0...761139c. Read the comment docs.

@julianKatz julianKatz marked this pull request as ready for review June 1, 2021 19:49
@julianKatz julianKatz changed the title Add kind 1.22 to our testing Add kind 1.22 Github Workflow Jun 1, 2021
@julianKatz
Copy link
Contributor Author

Once @sozercan pushes the node image to the OPA repository, I'll update the GitHub Action with that image path

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan LGTY?

This PR adds a separate github workflow for testing k8s 1.22 via a
custom-built k8s 1.22 node image.  1.22 isn't currently available under
kindest/node on docker hub, as 1.22 hasn't been officially released.

sozercan built and pushed this image from the k8s GitHub repo.  Once k8s
1.22 is available via the typical kindest/node pathway, the changes in
this PR should be removed.

Signed-off-by: juliankatz <juliankatz@google.com>
@sozercan
Copy link
Member

sozercan commented Jun 2, 2021

@sozercan sozercan merged commit 7690115 into open-policy-agent:master Jun 2, 2021
@julianKatz julianKatz deleted the kind-122-support branch June 10, 2021 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants