Use containerized kustomize #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Per our conversation, we should Dockerize all invocations so the build file is using a consistent version of Kustomize across the board |
willbeason
force-pushed
the
fix-kustomize
branch
from
809dd5b
to
566964d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1395 +/- ##
==========================================
- Coverage 50.06% 50.04% -0.03%
==========================================
Files 73 75 +2
Lines 5019 5061 +42
==========================================
+ Hits 2513 2533 +20
- Misses 2155 2178 +23
+ Partials 351 350 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
willbeason
force-pushed
the
fix-kustomize
branch
from
566964d
to
bd3c80b
Compare
willbeason
changed the title
willbeason
force-pushed
the
fix-kustomize
branch
4 times, most recently
from
590349d
to
4829dcc
Compare
sozercan
reviewed
Jul 13, 2021
sozercan
reviewed
Jul 13, 2021
sozercan
reviewed
Jul 13, 2021
willbeason
force-pushed
the
fix-kustomize
branch
from
4829dcc
to
37e6b43
Compare
willbeason
force-pushed
the
fix-kustomize
branch
from
37e6b43
to
a31cb92
Compare
Rather than relying on the developer's installed kustomize, use dockerized kustomize so behavior isn't dependnet on setup. Also update kustomize version to v4.1.3 This commit does not change other tools to be dockerized, for example kubectl. Signed-off-by: Will Beason <willbeason@google.com>
willbeason
force-pushed
the
fix-kustomize
branch
from
a31cb92
to
9bba778
Compare
julianKatz
pushed a commit
to julianKatz/gatekeeper
that referenced
this pull request
Jul 27, 2021
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com> Signed-off-by: juliankatz <juliankatz@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag is
--load-restrictor, not--load_restrictorWithout change,
make deploy-mutationshows:With the change,
make deploy-mutationsucceeds.I'm using kustomize v4.1.3:
Signed-off-by: Will Beason willbeason@google.com