Create gator root command #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willbeason
force-pushed
the
root-cmd
branch
3 times, most recently
from
3043b3a
to
7b69551
Compare
Signed-off-by: Will Beason <willbeason@google.com>
sozercan
reviewed
Jun 25, 2021
maxsmythe
approved these changes
Jun 26, 2021
Per decision in weekly meeting, make the "gator" root command and "test" the subcommand in charge of running the tests. This frees us up to add other subcommands that we want to do later. Signed-off-by: Will Beason <willbeason@google.com>
willbeason
added
the
authorship-tooling
sozercan
approved these changes
Jun 29, 2021
Codecov Report
@@ Coverage Diff @@
## master #1403 +/- ##
==========================================
- Coverage 49.65% 49.63% -0.03%
==========================================
Files 68 68
Lines 4926 4926
==========================================
- Hits 2446 2445 -1
- Misses 2136 2137 +1
Partials 344 344
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
julianKatz
pushed a commit
to julianKatz/gatekeeper
that referenced
this pull request
Jul 8, 2021
* read test files Signed-off-by: Will Beason <willbeason@google.com> * Make gator root command Per decision in weekly meeting, make the "gator" root command and "test" the subcommand in charge of running the tests. This frees us up to add other subcommands that we want to do later. Signed-off-by: Will Beason <willbeason@google.com> Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com> Signed-off-by: juliankatz <juliankatz@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per meeting, the Gatekeeper CLI root command is named "gator", and we will add several subcommands. The current one is named "test".
The changes for this PR are on top of willbeason/files. Only changes in the commit named "Make gator root command" need to be reviewed - this PR will not be merged until #1398 is merged.