make resourcequota and priorityClassName's optional #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsmythe
requested changes
Jul 10, 2021
cmd/build/helmify/main.go
Outdated
| } | ||
|
|
||
| if name == "gatekeeper-controller-manager" && kind == DeploymentKind { | ||
| obj = strings.Replace(obj, " priorityClassName: system-cluster-critical", " {{- if .Values.resourceQuota }} \n priorityClassName: {{ .Values.controllerManager.priorityClassName }}\n {{- end }}", 1) |
There was a problem hiding this comment.
should this be gated on values.controllerManager.priortyClassName, and similar for audit?
There was a problem hiding this comment.
thank you so much, it is my bad 🤦🏻♂️ it should be values.audit.priorityClassName. I fixed it.
There was a problem hiding this comment.
I'm still seeing a test against resourceQuota?: if .Values.resourceQuota
There was a problem hiding this comment.
this time, it should be ok @maxsmythe. 🙏
I updated the code according to your reviews @maxsmythe, thanks for helping me to fix the issues. 🙏 |
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
|
How can we include this PR in the next milestones @sozercan? I just want to know the version when this PR gets released. |
julianKatz
pushed a commit
to julianKatz/gatekeeper
that referenced
this pull request
Jul 27, 2021
…t#1425) Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com> Signed-off-by: juliankatz <juliankatz@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com
What this PR does / why we need it:
This PR aims to provide conditional logic for resource
ResourceQuotaand fieldpriorityClassNamefor bothauditandcontroller-managerdeployment resource for Gatekeeper.Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #1421
Special notes for your reviewer: