Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto format linters #1433

Merged
merged 1 commit into from Jul 13, 2021
Merged

Conversation

willbeason
Copy link
Member

This PR enables golangci-lint linters which have automatic fixes. If we like how this looks, enabling these linters has little developer overhead as any problems found by the enabled linters can be fixed automatically with golangci-lint run --fix

WDYT? The main idea here is consistency with whitespace usage, comments, and variable grouping.

Signed-off-by: Will Beason willbeason@google.com

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan
Copy link
Member

@willbeason looks like 2 conflicts now

Signed-off-by: Will Beason <willbeason@google.com>
@willbeason willbeason merged commit 643adf7 into open-policy-agent:master Jul 13, 2021
@willbeason willbeason deleted the auto-format branch July 13, 2021 20:39
julianKatz pushed a commit to julianKatz/gatekeeper that referenced this pull request Jul 27, 2021
Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: juliankatz <juliankatz@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants