Benchmark AssignMutator.Mutate code #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current benchmarks on my machine: |
Codecov Report
@@ Coverage Diff @@
## master #1437 +/- ##
==========================================
+ Coverage 50.41% 50.46% +0.05%
==========================================
Files 77 77
Lines 5108 5108
==========================================
+ Hits 2575 2578 +3
+ Misses 2182 2180 -2
+ Partials 351 350 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
maxsmythe
approved these changes
Jul 13, 2021
sozercan
approved these changes
Jul 14, 2021
Add benchmark tests for AssignMutator.Mutate. In writing this, I found that mutating objects takes about 10x longer than not mutating objects. Profiling reveals that we spend over 90% of compute time in AssingMutator.Value(), where we convert from the raw JSON value to a literal Go struct. In a separate PR I'll suggest a change that resolves this performance issue. Most likely we'll want to cache the assigned value. We can then either reflect.DeepCopy the value or assign the cached value directly, depending on whether we feel it safe. Signed-off-by: Will Beason <willbeason@google.com>
julianKatz
pushed a commit
to julianKatz/gatekeeper
that referenced
this pull request
Jul 27, 2021
Add benchmark tests for AssignMutator.Mutate. In writing this, I found that mutating objects takes about 10x longer than not mutating objects. Profiling reveals that we spend over 90% of compute time in AssingMutator.Value(), where we convert from the raw JSON value to a literal Go struct. In a separate PR I'll suggest a change that resolves this performance issue. Most likely we'll want to cache the assigned value. We can then either reflect.DeepCopy the value or assign the cached value directly, depending on whether we feel it safe. Signed-off-by: Will Beason <willbeason@google.com> Signed-off-by: juliankatz <juliankatz@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add benchmark tests for AssignMutator.Mutate.
In writing this, I found that mutating objects takes about 10x longer
than not mutating objects. Profiling reveals that we spend over 90% of
compute time in AssingMutator.Value(), where we convert from the raw
JSON value to a literal Go struct.
In a separate PR I'll suggest a change that resolves this performance
issue. Most likely we'll want to cache the assigned value. We can then
either reflect.DeepCopy the value or assign the cached value directly,
depending on whether we feel it safe.
Signed-off-by: Will Beason willbeason@google.com