[gk-test] Run case #1446
Merged
[gk-test] Run case #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willbeason
added
the
authorship-tooling
Codecov Report
@@ Coverage Diff @@
## master #1446 +/- ##
==========================================
+ Coverage 51.64% 51.87% +0.23%
==========================================
Files 78 80 +2
Lines 7288 7429 +141
==========================================
+ Hits 3764 3854 +90
- Misses 3172 3206 +34
- Partials 352 369 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
willbeason
pushed a commit
to willbeason/gatekeeper
that referenced
this pull request
Jul 15, 2021
This lets us read Suites from the disk. Per open-policy-agent#1446, we aren't doing Assertions for pre-alpha so I haven't added those annotations yet. Signed-off-by: Will Beason <willbeason@google.com>
willbeason
pushed a commit
to willbeason/gatekeeper
that referenced
this pull request
Jul 15, 2021
This lets us read Suites from the disk. Per open-policy-agent#1446, we aren't doing Assertions for pre-alpha so I haven't added those annotations yet. Signed-off-by: Will Beason <willbeason@google.com>
willbeason
pushed a commit
to willbeason/gatekeeper
that referenced
this pull request
Jul 16, 2021
This lets us read Suites from the disk. Per open-policy-agent#1446, we aren't doing Assertions for pre-alpha so I haven't added those annotations yet. Signed-off-by: Will Beason <willbeason@google.com>
willbeason
force-pushed
the
run-case
branch
2 times, most recently
from
e68a8c8
to
5f3234c
Compare
willbeason
pushed a commit
to willbeason/gatekeeper
that referenced
this pull request
Jul 20, 2021
This lets us read Suites from the disk. Per open-policy-agent#1446, we aren't doing Assertions for pre-alpha so I haven't added those annotations yet. Signed-off-by: Will Beason <willbeason@google.com>
added 2 commits
July 22, 2021 11:57
A first pass at printing output similar to what is shown for "go test". Sadly we can't just use testing.T without asking users to write their own unit tests. There is no accessible printer that automatically does this formatting for us, so we must replicate it. This does not print output as tests are run even though the result output appears to suggest this. In the future we will do so, but as we don't yet run tests that would be premature. The point here is to make the output consistent with "go test". Signed-off-by: Will Beason <willbeason@google.com>
Add logic for running individual test cases. Now that we've compiled the constraints, all we need to do is Review() the specified objects and compare the Results with what the user specified. This PR does not add Assertion functionality - we'll do that for alpha, not pre-alpha. Also add unit tests that verify we are, in fact, running the test cases. Signed-off-by: Will Beason <willbeason@google.com>
willbeason
pushed a commit
to willbeason/gatekeeper
that referenced
this pull request
Jul 22, 2021
This lets us read Suites from the disk. Per open-policy-agent#1446, we aren't doing Assertions for pre-alpha so I haven't added those annotations yet. Signed-off-by: Will Beason <willbeason@google.com>
willbeason
pushed a commit
that referenced
this pull request
Jul 27, 2021
* Print output of tests similar go go test A first pass at printing output similar to what is shown for "go test". Sadly we can't just use testing.T without asking users to write their own unit tests. There is no accessible printer that automatically does this formatting for us, so we must replicate it. This does not print output as tests are run even though the result output appears to suggest this. In the future we will do so, but as we don't yet run tests that would be premature. The point here is to make the output consistent with "go test". Signed-off-by: Will Beason <willbeason@google.com> * Run test cases Add logic for running individual test cases. Now that we've compiled the constraints, all we need to do is Review() the specified objects and compare the Results with what the user specified. This PR does not add Assertion functionality - we'll do that for alpha, not pre-alpha. Also add unit tests that verify we are, in fact, running the test cases. Signed-off-by: Will Beason <willbeason@google.com> * Add json annotations for Suites This lets us read Suites from the disk. Per #1446, we aren't doing Assertions for pre-alpha so I haven't added those annotations yet. Signed-off-by: Will Beason <willbeason@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1445.
Add logic for running individual test cases. Now that we've compiled the
constraints, all we need to do is Review() the specified objects and
compare the Results with what the user specified.
This PR does not add Assertion functionality - we'll do that for alpha,
not pre-alpha.
Also add unit tests that verify we are, in fact, running the test cases.