Fix support for DELETE #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
maxsmythe
approved these changes
Jun 21, 2019
|
Sorry, just noticed the DELETE question. There is some reservation about enabling DELETE by default in that there could be risk of landing users in an unrecoverable state. We would need to think through the possibilities and make sure there is an escape hatch if such a state is possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rita Zhang rita.z.zhang@gmail.com
Fixes #144
oldObjectis not nil for k8s v1.15+, populate admission requestobjectwitholdObjectbefore passing the request to validation and reviewNOTE:
admissionregistrationv1beta1.DELETEto the validation webhook config by default. Users can do that manually after it is deployed. Do we need a flag to enable DELETE by default as part of the initial deployment?