initial external data integration for validation #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1573 +/- ##
==========================================
+ Coverage 54.25% 54.37% +0.11%
==========================================
Files 93 94 +1
Lines 8082 8193 +111
==========================================
+ Hits 4385 4455 +70
- Misses 3356 3391 +35
- Partials 341 347 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
maxsmythe
reviewed
Sep 24, 2021
ritazh
reviewed
Sep 24, 2021
ritazh
reviewed
Sep 24, 2021
ritazh
reviewed
Sep 24, 2021
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
14 tasks
ritazh
reviewed
Sep 30, 2021
ritazh
reviewed
Sep 30, 2021
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
maxsmythe
approved these changes
Sep 30, 2021
pkg/controller/externaldata/externaldata_controller_suite_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
sozercan
force-pushed
the
init-externaldata
branch
from
6634aab
to
e507129
Compare
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
ritazh
approved these changes
Oct 5, 2021
ritazh
approved these changes
Oct 5, 2021
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sertac Ozercan sozercan@gmail.com
What this PR does / why we need it:
As discussed this is the initial PR for external data for validation only. After this is merged, I'll rebase #1506 for mutation.
Depends on open-policy-agent/frameworks#134
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: