feat: Ability to use Image SHA for gatekeeper and gatekeeper-crd images #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…open-policy-agent#1674 This commit checks if image.release is defined in the values.yaml if not defined it will ignore the image.release field and only use the values of image.repository and image.crdRepository to set the "image" in gatekeeper audit /controller deployment yamls. With the current implementation there is only one field defined "image.release" which restrics the use of image-tag:release and not allowing SHA along with "image"(e.g image@SHA) for GK and GK-CRD repository Signed-off-by: Priya Shet priya.shet@gmail.com Signed-off-by: Priya Shetpriya.shet@gmail.com <priya.shet@gmail.com>
priyamshet
changed the title
|
@sozercan , i had to resubmit the PR due to github branch merge issue, Please let me know your feedback on this PR. thank you for your time. |
sozercan
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1759 +/- ##
==========================================
+ Coverage 51.96% 52.14% +0.18%
==========================================
Files 98 98
Lines 8781 8781
==========================================
+ Hits 4563 4579 +16
+ Misses 3852 3837 -15
+ Partials 366 365 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
helm upgrade is failing due to k8s version bump, opened a fix in #1766 |
|
Thank you so much @sozercan for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… Gatekeeper helm charts #1659
This commit checks if image.release is defined in the values.yaml
if not defined it will ignore the image.release field and only use the values of
image.repository and image.crdRepository to set the "image" in gatekeeper audit /controller
deployment yamls.
With the current implementation there is only one field defined "image.release" which restrics the use of
image-tag:release and not allowing SHA along with "image"(e.g image@SHA) for GK and GK-CRD repository
Signed-off-by: Priya Shet priya.shet@gmail.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using fixes #1659 (, fixes #1659) format, will close the issue(s) when the PR gets merged):
Fixes #1659
Special notes for your reviewer: