feat: Support suffix-based matching for resources #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devholic
changed the title
maxsmythe
reviewed
Jan 19, 2022
devholic
pushed a commit
to devholic/gatekeeper
that referenced
this pull request
Jan 19, 2022
open-policy-agent#1796 (comment) Signed-off-by: Sunghoon Kang <hoon@linecorp.com>
devholic
force-pushed
the
#1571-suffix-wildcard-support
branch
from
ad8d595
to
17fa858
Compare
sozercan
reviewed
Jan 19, 2022
|
Can we update e2e to cover prefix (or suffix) match too? https://github.com/open-policy-agent/gatekeeper/blob/master/test/bats/tests/sync_with_exclusion.yaml#L9 |
devholic
pushed a commit
to devholic/gatekeeper
that referenced
this pull request
Jan 20, 2022
open-policy-agent#1796 (comment) Signed-off-by: Sunghoon Kang <hoon@linecorp.com>
devholic
pushed a commit
to devholic/gatekeeper
that referenced
this pull request
Jan 20, 2022
open-policy-agent#1796 (comment) Signed-off-by: Sunghoon Kang <hoon@linecorp.com>
added 4 commits
January 20, 2022 12:19
open-policy-agent#1571 It would be useful to allow suffix-based matching for resource names, in addition to prefix-based matching. This commit implements this feature by extending `PrefixWildcard` type instead of using regex since it might be problematic for large numbers of resources as @maxsmythe commented on the issue. Signed-off-by: Sunghoon Kang <hoon@linecorp.com>
open-policy-agent#1796 (comment) Signed-off-by: Sunghoon Kang <hoon@linecorp.com>
open-policy-agent#1796 (comment) Signed-off-by: Sunghoon Kang <hoon@linecorp.com>
open-policy-agent#1796 (comment) Signed-off-by: Sunghoon Kang <hoon@linecorp.com>
devholic
force-pushed
the
#1571-suffix-wildcard-support
branch
from
71f7757
to
5af3a52
Compare
Codecov Report
@@ Coverage Diff @@
## master #1796 +/- ##
==========================================
- Coverage 52.08% 52.03% -0.05%
==========================================
Files 99 99
Lines 8821 8828 +7
==========================================
Hits 4594 4594
- Misses 3865 3870 +5
- Partials 362 364 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It would be useful to allow suffix-based matching for resource names, in addition to prefix-based matching.
This commit implements this feature by extending
PrefixWildcardtype instead of using regex since it might be problematic for large numbers of resources as @maxsmythe commented on the issue.Which issue(s) this PR fixes:
Fixes #1571
Special notes for your reviewer:
None