Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Change gator test to gator verify #1799

Merged
merged 1 commit into from Jan 19, 2022

Conversation

julianKatz
Copy link
Contributor

@julianKatz julianKatz commented Jan 19, 2022

In this week's community meeting, we discussed naming that would
differentiate the current gator test from a new command that validates
entire manifests against sets of policies (#1786). We decided to align
gator's commands with the verbs used in conftest.

Accordingly, what has previously been known as gator test will be
henceforth called:

gator verify

This PR changes package names and the name of the command. The
aforementioned PR will rebase on this PR to include the name changes.

Signed-off-by: juliankatz juliankatz@google.com

In this weeks community meeting, we discussed naming that would
differentiate the current `gator test` from a new command that validates
entire manifests against sets of policies (open-policy-agent#1786).  We decided to align
gator's commands with the verbs used in conftest.

Accordingly, what has previously been known as `gator test` will be
henceforth called:

`gator verify`

This PR changes package names and the name of the command.  The
aforementioned PR will rebase on this PR to include the name changes.

Signed-off-by: juliankatz <juliankatz@google.com>
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #1799 (445ebc7) into master (8e580b6) will decrease coverage by 0.24%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1799      +/-   ##
==========================================
- Coverage   52.08%   51.83%   -0.25%     
==========================================
  Files          99       99              
  Lines        8821     8826       +5     
==========================================
- Hits         4594     4575      -19     
- Misses       3865     3886      +21     
- Partials      362      365       +3     
Flag Coverage Δ
unittests 51.83% <0.00%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/target/target.go 67.96% <0.00%> (-0.45%) ⬇️
pkg/watch/registrar.go 73.15% <0.00%> (-1.51%) ⬇️
pkg/watch/replay.go 78.97% <0.00%> (-2.28%) ⬇️
...onstrainttemplate/constrainttemplate_controller.go 56.97% <0.00%> (-2.17%) ⬇️
pkg/readiness/object_tracker.go 82.91% <0.00%> (-1.07%) ⬇️
pkg/readiness/ready_tracker.go 69.83% <0.00%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7784296...445ebc7. Read the comment docs.

@julianKatz julianKatz changed the title Change gator test to gator verify refactor: Change gator test to gator verify Jan 19, 2022
@julianKatz julianKatz merged commit 075274d into open-policy-agent:master Jan 19, 2022
@julianKatz julianKatz deleted the change-gator-names branch January 19, 2022 22:14
julianKatz added a commit to julianKatz/gatekeeper that referenced this pull request Jan 19, 2022
A previous PR (open-policy-agent#1799) changed the gator test command to now be `gator
verify`.  That PR left out docs changes.  Those docs updates are
included here.

Signed-off-by: juliankatz <juliankatz@google.com>
julianKatz added a commit that referenced this pull request Jan 19, 2022
* Update docs: gator test --> gator verify

A previous PR (#1799) changed the gator test command to now be `gator
verify`.  That PR left out docs changes.  Those docs updates are
included here.

Signed-off-by: juliankatz <juliankatz@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants