build: Update Gatekeeper with frameworks interface changes #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, enforce using a consistent import for the frameworks Client package. This ensures automated changes are easier, and ensures the Client type is referenced consistently throughout the code (instead of being confused with the k8s API client. Signed-off-by: Will Beason <willbeason@google.com>
willbeason
changed the title
|
The big thing here is that the Client is easier to instantiate, so all of the places we do this are now smaller. |
|
It looks like this is failing due to lint errors from a linter added by this PR? |
|
Looks like there's a diff in go mod |
added 2 commits
February 14, 2022 07:53
Signed-off-by: Will Beason <willbeason@google.com>
willbeason
force-pushed
the
update-frameworks
branch
from
6475320
to
709762d
Compare
added 3 commits
February 14, 2022 08:20
Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
|
@sozercan Fixed |
Codecov Report
@@ Coverage Diff @@
## master #1845 +/- ##
==========================================
+ Coverage 52.12% 52.21% +0.09%
==========================================
Files 100 100
Lines 8956 8952 -4
==========================================
+ Hits 4668 4674 +6
+ Misses 3911 3903 -8
+ Partials 377 375 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, enforce using a consistent import for the frameworks Client
package. This ensures automated changes are easier, and ensures the
Client type is referenced consistently throughout the code (instead of
being confused with the k8s API client.
Signed-off-by: Will Beason willbeason@google.com