Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for mutation annotations #1846

Merged
merged 2 commits into from Feb 12, 2022

Conversation

chewong
Copy link
Member

@chewong chewong commented Feb 11, 2022

What this PR does / why we need it:

Adding test cases and documentations for mutation annotations gatekeeper.sh/mutation-id and gatekeeper.sh/mutations.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #1561

Special notes for your reviewer:

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2022

Codecov Report

Merging #1846 (03c3ba5) into master (b36e855) will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1846      +/-   ##
==========================================
- Coverage   52.27%   52.12%   -0.16%     
==========================================
  Files         100      100              
  Lines        8956     8956              
==========================================
- Hits         4682     4668      -14     
- Misses       3900     3910      +10     
- Partials      374      378       +4     
Flag Coverage Δ
unittests 52.12% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/readiness/list.go 79.41% <0.00%> (-11.77%) ⬇️
...onstrainttemplate/constrainttemplate_controller.go 57.93% <0.00%> (-1.69%) ⬇️
pkg/readiness/object_tracker.go 82.91% <0.00%> (-1.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b36e855...03c3ba5. Read the comment docs.

@chewong chewong force-pushed the fix-1561 branch 2 times, most recently from 8446e1c to 03c3ba5 Compare February 11, 2022 20:52
Signed-off-by: Ernest Wong <chuwon@microsoft.com>
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sozercan sozercan merged commit 4e62ac3 into open-policy-agent:master Feb 12, 2022
@chewong chewong deleted the fix-1561 branch February 12, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mutation-annotations enabled does not add the expected annotations
4 participants