Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run benchmarks when running tests #1898

Merged
merged 6 commits into from Mar 15, 2022

Conversation

mozillazg
Copy link
Contributor

@mozillazg mozillazg commented Mar 5, 2022

What this PR does / why we need it:

Run benchmarks when running tests to keep benchmarks always working.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #1761

Special notes for your reviewer:

depend on #1896 and #1897

@mozillazg mozillazg closed this Mar 12, 2022
@mozillazg mozillazg reopened this Mar 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2022

Codecov Report

Merging #1898 (409d3b1) into master (80d9993) will increase coverage by 0.92%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1898      +/-   ##
==========================================
+ Coverage   52.13%   53.05%   +0.92%     
==========================================
  Files         100      100              
  Lines        8958     8958              
==========================================
+ Hits         4670     4753      +83     
+ Misses       3912     3813      -99     
- Partials      376      392      +16     
Flag Coverage Δ
unittests 53.05% <ø> (+0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onstrainttemplate/constrainttemplate_controller.go 56.25% <0.00%> (-2.41%) ⬇️
pkg/readiness/ready_tracker.go 70.33% <0.00%> (+0.50%) ⬆️
...mutation/mutators/assignmeta/assignmeta_mutator.go 32.97% <0.00%> (+1.06%) ⬆️
pkg/readiness/object_tracker.go 83.98% <0.00%> (+1.06%) ⬆️
pkg/mutation/mutators/assign/assign_mutator.go 36.86% <0.00%> (+1.51%) ⬆️
pkg/webhook/common.go 72.00% <0.00%> (+6.00%) ⬆️
pkg/webhook/policy.go 36.36% <0.00%> (+7.98%) ⬆️
.../mutation/mutators/modifyset/modify_set_mutator.go 51.85% <0.00%> (+26.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80d9993...409d3b1. Read the comment docs.

@mozillazg mozillazg marked this pull request as ready for review March 12, 2022 02:58
@mozillazg
Copy link
Contributor Author

Ready for review.

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxsmythe maxsmythe merged commit 7767c01 into open-policy-agent:master Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken benchmarks
5 participants