Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add contributing guide #1945

Merged
merged 1 commit into from Apr 1, 2022
Merged

Conversation

ritazh
Copy link
Member

@ritazh ritazh commented Mar 28, 2022

Signed-off-by: Rita Zhang rita.z.zhang@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #631

Special notes for your reviewer:
NOTE: I will update all the versioned docs after initial review is completed.

@codecov-commenter
Copy link

Codecov Report

Merging #1945 (1f2f831) into master (6c58cad) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1945      +/-   ##
==========================================
- Coverage   53.23%   53.19%   -0.05%     
==========================================
  Files         100      100              
  Lines        8986     8986              
==========================================
- Hits         4784     4780       -4     
- Misses       3809     3812       +3     
- Partials      393      394       +1     
Flag Coverage Δ
unittests 53.19% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onstrainttemplate/constrainttemplate_controller.go 55.28% <0.00%> (-1.69%) ⬇️
pkg/readiness/object_tracker.go 83.98% <0.00%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ff57f6...1f2f831. Read the comment docs.

Copy link
Member

@chewong chewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

website/docs/help.md Show resolved Hide resolved
website/docs/help.md Show resolved Hide resolved
website/docs/help.md Show resolved Hide resolved
website/docs/help.md Show resolved Hide resolved
website/docs/help.md Show resolved Hide resolved
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sozercan sozercan added this to the v3.8.0 milestone Apr 1, 2022
channel on [OPA Slack](https://slack.openpolicyagent.org/).
- File [GitHub Issues](https://github.com/open-policy-agent/gatekeeper/issues)
to report bugs, request features, or ask questions asynchronously.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small item, otherwise LGTM

Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
@ritazh ritazh merged commit 301c0b7 into open-policy-agent:master Apr 1, 2022
@ritazh ritazh deleted the contributing branch April 4, 2022 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add contributing guide
5 participants