Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update deployment to include mutation-status operation #1966

Merged

Conversation

ritazh
Copy link
Member

@ritazh ritazh commented Apr 4, 2022

Signed-off-by: Rita Zhang rita.z.zhang@gmail.com

What this PR does / why we need it:
Currently Gatekeeper deployment does not include the mutation-status operation by default. Note: helm chart includes it by default.

{{ if not .Values.disableMutation}}- --operation=mutation-status{{- end }}
This updates the deployment yaml to ensure it is included by default.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes https://github.com/open-policy-agent/gatekeeper/pull/1937/files#r838163357

Special notes for your reviewer:

@sozercan sozercan added this to the v3.8.0 milestone Apr 4, 2022
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
@chewong chewong force-pushed the fix-deployment-mutation-status branch from 1c29251 to 978978f Compare April 4, 2022 21:55
@ritazh ritazh merged commit bfc5ec8 into open-policy-agent:master Apr 5, 2022
@ritazh ritazh deleted the fix-deployment-mutation-status branch April 5, 2022 01:36
@thomasmckay
Copy link
Contributor

Is this a candidate for backport to 3.7?

@maxsmythe
Copy link
Contributor

IMO it'd make sense to backport this

chewong pushed a commit to chewong/gatekeeper that referenced this pull request Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants