Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Upgrade OPA to v0.39.0 #1968

Merged
merged 4 commits into from Apr 5, 2022

Conversation

willbeason
Copy link
Member

Upgrade OPA in frameworks library

Signed-off-by: Will Beason <willbeason@google.com>
Will Beason added 2 commits April 4, 2022 09:12
The current version we're using is at the end of its support lifecycle.
Also, 1.45 fully supports Go 1.18 for when we need to upgrade.

Signed-off-by: Will Beason <willbeason@google.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1968 (b7f544a) into master (21a9de7) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1968      +/-   ##
==========================================
- Coverage   53.91%   53.78%   -0.14%     
==========================================
  Files         103      103              
  Lines        9147     9147              
==========================================
- Hits         4932     4920      -12     
- Misses       3839     3848       +9     
- Partials      376      379       +3     
Flag Coverage Δ
unittests 53.78% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/readiness/list.go 79.41% <0.00%> (-11.77%) ⬇️
pkg/watch/replay.go 78.97% <0.00%> (-2.28%) ⬇️
...onstrainttemplate/constrainttemplate_controller.go 55.87% <0.00%> (-0.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21a9de7...b7f544a. Read the comment docs.

@sozercan
Copy link
Member

sozercan commented Apr 4, 2022

do we want to hold this until v3.9?

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritazh
Copy link
Member

ritazh commented Apr 5, 2022

do we want to hold this until v3.9?

IMO if the new opa version does not introduce any issues, we should bump it now before releasing 3.8 since 3.9 will be awhile. WDYT?

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willbeason willbeason merged commit b1715cd into open-policy-agent:master Apr 5, 2022
@willbeason willbeason deleted the upgrade-opa branch April 5, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants