Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add applyTo field for ModifySet in mutation docs #2056

Merged
merged 3 commits into from Aug 2, 2022

Conversation

davis-haba
Copy link
Contributor

The existing docs for ModifySet does not have an applyTo field, which is required. This change adds the missing field.

What this PR does / why we need it:

Minor docs update. Adds a required field to the ModifySet example in the mutations docs.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

The existing docs for ModifySet does not have an `applyTo` field, which is required. This change adds the missing field.
@davis-haba davis-haba requested a review from maxsmythe May 18, 2022 22:07
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We may want to update the versioned docs as well (as far back as modifySet exists for them)

@maxsmythe maxsmythe requested review from ritazh and sozercan May 20, 2022 00:15
@sozercan
Copy link
Member

@davis-haba looks like we need DCO signed

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending versioned docs update and DCO

@ritazh
Copy link
Member

ritazh commented May 27, 2022

@davis-haba looks like we need DCO signed

@davis-haba bump

@stale
Copy link

stale bot commented Jul 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 31, 2022
@davis-haba davis-haba merged commit 86a2ded into master Aug 2, 2022
@davis-haba davis-haba deleted the add-applyTo-modifySet-public-docs branch August 2, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants