Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Upgrade Constraint Framework to v0.7.0 #2272

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

maxsmythe
Copy link
Contributor

This upgrades opa to v0.44.0 and should reduce
lock contention between data caching and policy evaluation.

Fixes #2060

Signed-off-by: Max Smythe smythe@google.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

This upgrades opa to v0.44.0 and should reduce
lock contention between data caching and policy evaluation.

Signed-off-by: Max Smythe <smythe@google.com>
@codecov-commenter
Copy link

Codecov Report

Base: 53.28% // Head: 53.20% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (e55ea51) compared to base (8a3e215).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2272      +/-   ##
==========================================
- Coverage   53.28%   53.20%   -0.08%     
==========================================
  Files         115      115              
  Lines       10131    10131              
==========================================
- Hits         5398     5390       -8     
- Misses       4315     4320       +5     
- Partials      418      421       +3     
Flag Coverage Δ
unittests 53.20% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onstrainttemplate/constrainttemplate_controller.go 54.30% <0.00%> (-2.16%) ⬇️
pkg/readiness/object_tracker.go 82.91% <0.00%> (-1.07%) ⬇️
pkg/readiness/list.go 91.17% <0.00%> (+11.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maxsmythe maxsmythe merged commit 1d33b6b into open-policy-agent:master Sep 16, 2022
ritazh added a commit that referenced this pull request Oct 6, 2022
…rk to v0.7.0 (#2299)

perf: Upgrade Constraint Framework to v0.7.0

This upgrades opa to v0.44.0 and should reduce
lock contention between data caching and policy evaluation.

Signed-off-by: Max Smythe <smythe@google.com>

Signed-off-by: Max Smythe <smythe@google.com>
Co-authored-by: Max Smythe <smythe@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lock Contention
3 participants