Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update default auditChunkSize in readme #2303

Merged
merged 3 commits into from Oct 1, 2022

Conversation

meons
Copy link
Contributor

@meons meons commented Sep 29, 2022

As per values.yaml, the parameter auditChunkSize is set to 500.

Signed-off-by: Simeon Bobylev simeon.bobylev@gmail.com

What this PR does / why we need it: Documentation fix

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer: -

@meons meons changed the title Update default auditChunkSize in readme docs: Update default auditChunkSize in readme Sep 29, 2022
@sozercan
Copy link
Member

@meons thanks for the PR! Gatekeeper helm chart is autogenerated. Can you revert your current change, and make change in

| auditChunkSize | Chunk size for listing cluster resources for audit (alpha feature) | `0` |
then run make manifests and commit and push the changes please?

meons and others added 3 commits October 1, 2022 12:51
As per values.yaml, the parameter `auditChunkSize` is set to 500.

Signed-off-by: Simeon Bobylev <simeon.bobylev@gmail.com>
Signed-off-by: Siméon Bobylev <simeon.bobylev@nagra.com>
This reverts commit fc76507.

Signed-off-by: Siméon Bobylev <simeon.bobylev@nagra.com>
Signed-off-by: Siméon Bobylev <simeon.bobylev@nagra.com>
@meons
Copy link
Contributor Author

meons commented Oct 1, 2022

@sozercan sorry I should have read https://open-policy-agent.github.io/gatekeeper/website/docs/help/#contributing-to-helm-chart first. Should be fine now.

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@codecov-commenter
Copy link

Codecov Report

Base: 53.39% // Head: 53.36% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (5ced085) compared to base (35b9cbd).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2303      +/-   ##
==========================================
- Coverage   53.39%   53.36%   -0.03%     
==========================================
  Files         116      116              
  Lines       10174    10174              
==========================================
- Hits         5432     5429       -3     
- Misses       4322     4324       +2     
- Partials      420      421       +1     
Flag Coverage Δ
unittests 53.36% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onstrainttemplate/constrainttemplate_controller.go 53.34% <0.00%> (-3.12%) ⬇️
pkg/readiness/ready_tracker.go 70.33% <0.00%> (+0.50%) ⬆️
pkg/readiness/object_tracker.go 83.98% <0.00%> (+1.06%) ⬆️
pkg/readiness/list.go 91.17% <0.00%> (+11.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sozercan sozercan merged commit b2b566c into open-policy-agent:master Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants