Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore all stackdriver errors if --stackdriver-only-when-available is set #2304

Merged
merged 2 commits into from Sep 30, 2022

Conversation

maxsmythe
Copy link
Contributor

This is to handle issues where the heuristics in google.FindDefaultCredentials() falsely indicate stackdriver is present, leading to the Gatekeeper pod crash looping.

Signed-off-by: Max Smythe smythe@google.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

…le is set

Signed-off-by: Max Smythe <smythe@google.com>
@codecov-commenter
Copy link

Codecov Report

Base: 53.32% // Head: 53.44% // Increases project coverage by +0.11% 🎉

Coverage data is based on head (3b8e36e) compared to base (512d97e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2304      +/-   ##
==========================================
+ Coverage   53.32%   53.44%   +0.11%     
==========================================
  Files         116      116              
  Lines       10174    10174              
==========================================
+ Hits         5425     5437      +12     
+ Misses       4327     4318       -9     
+ Partials      422      419       -3     
Flag Coverage Δ
unittests 53.44% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onstrainttemplate/constrainttemplate_controller.go 57.65% <0.00%> (+2.87%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maxsmythe maxsmythe merged commit 9a56db9 into open-policy-agent:master Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants