Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: high-risk vulnerabilities caused by low version of kubebuilder and yq #2505

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

fengshunli
Copy link
Contributor

No description provided.

@fengshunli fengshunli changed the title fix: high-risk vulnerabilities caused by low version of kubebuilder a… fix: high-risk vulnerabilities caused by low version of kubebuilder and yq Jan 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2023

Codecov Report

Base: 53.88% // Head: 53.86% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (50b00a4) compared to base (bb11f3e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2505      +/-   ##
==========================================
- Coverage   53.88%   53.86%   -0.02%     
==========================================
  Files         116      116              
  Lines       10272    10272              
==========================================
- Hits         5535     5533       -2     
- Misses       4311     4312       +1     
- Partials      426      427       +1     
Flag Coverage Δ
unittests 53.86% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onstrainttemplate/constrainttemplate_controller.go 56.69% <0.00%> (-0.48%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Makefile Outdated Show resolved Hide resolved
Makefile Outdated
--build-arg ORAS_VERSION=$(ORAS_VERSION)
--build-arg ORAS_VERSION=$(ORAS_VERSION) \
--build-arg KUSTOMIZE_VERSION=$(KUSTOMIZE_VERSION) \
--build-arg KUBEBUILDER_VERSION=$(KUBEBUILDER_VERSION) \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--build-arg KUBEBUILDER_VERSION=$(KUBEBUILDER_VERSION) \
--build-arg KUBEBUILDER_VERSION=$(KUBEBUILDER_VERSION)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, otherwise lgtm

…nd yq

Signed-off-by: fsl <1171313930@qq.com>
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritazh ritazh merged commit 149fb90 into open-policy-agent:master Jan 12, 2023
davis-haba pushed a commit to davis-haba/gatekeeper that referenced this pull request Mar 7, 2023
…nd yq (open-policy-agent#2505)

Signed-off-by: fsl <1171313930@qq.com>

Signed-off-by: fsl <1171313930@qq.com>
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants