Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce gci to unify the order of package import #2545

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

Fish-pro
Copy link
Contributor

Signed-off-by: Fish-pro zechun.chen@daocloud.io

What this PR does / why we need it:

The order of package import for some files in the code is not uniform, and this pr introduces gci to regulate package import order

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

@Fish-pro Fish-pro changed the title Introduce gci to unify the order of package import feat: introduce gci to unify the order of package import Jan 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2023

Codecov Report

Base: 53.41% // Head: 53.42% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (b708fde) compared to base (5888706).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2545   +/-   ##
=======================================
  Coverage   53.41%   53.42%           
=======================================
  Files         120      120           
  Lines       10643    10643           
=======================================
+ Hits         5685     5686    +1     
+ Misses       4521     4520    -1     
  Partials      437      437           
Flag Coverage Δ
unittests 53.42% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onstrainttemplate/constrainttemplate_controller.go 57.17% <0.00%> (+0.23%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Fish-pro <zechun.chen@daocloud.io>
Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the PR!

@ritazh ritazh merged commit 4a27fbf into open-policy-agent:master Jan 31, 2023
davis-haba pushed a commit to davis-haba/gatekeeper that referenced this pull request Mar 7, 2023
…cy-agent#2545)

Introduce gci to unify the order of package import

Signed-off-by: Fish-pro <zechun.chen@daocloud.io>
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants