feat: add unconvert check for golang-lint #2554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fish-pro
force-pushed
the
chore/unconvert
branch
from
974728e
to
7d58bd8
Compare
acpana
approved these changes
Feb 1, 2023
Codecov ReportBase: 53.52% // Head: 53.52% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2554 +/- ##
=======================================
Coverage 53.52% 53.52%
=======================================
Files 120 120
Lines 10634 10634
=======================================
Hits 5692 5692
Misses 4507 4507
Partials 435 435
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@sozercan Thanks for update branch，Do you need me to rebase? |
Fish-pro
force-pushed
the
chore/unconvert
branch
from
59663d5
to
ce805b6
Compare
Signed-off-by: Zechun Chen <zechun.chen@daocloud.io>
Fish-pro
force-pushed
the
chore/unconvert
branch
from
ce805b6
to
546cc29
Compare
sozercan
approved these changes
Feb 10, 2023
davis-haba
pushed a commit
to davis-haba/gatekeeper
that referenced
this pull request
Mar 7, 2023
Signed-off-by: Zechun Chen <zechun.chen@daocloud.io>
davis-haba
pushed a commit
to davis-haba/gatekeeper
that referenced
this pull request
Mar 8, 2023
Signed-off-by: Zechun Chen <zechun.chen@daocloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Fish-pro zechun.chen@daocloud.io
What this PR does / why we need it:
➜ gatekeeper git:(chore/unconvert) golangci-lint run -c .golangci.yaml pkg/metrics/registry/registry.go:63:37: unnecessary conversion (unconvert) contents = append(contents, string(k)) ^ ➜ gatekeeper git:(chore/unconvert) ✗ golangci-lint run -c .golangci.yaml ➜ gatekeeper git:(chore/unconvert) ✗Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: