fix: add vendor manifests back #2558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
maxsmythe
approved these changes
Feb 1, 2023
build/tooling/vendormanifests.go
Outdated
| // This is used for vendoring frameworks to Gatekeeper. | ||
|
|
||
| //go:build tools | ||
| // +build tools |
There was a problem hiding this comment.
I think the comment line under //go:build needs to be empty?
Taking this from:
Constraints may appear in any kind of source file (not just Go), but they must appear near the top of the file, preceded only by blank lines and other line comments. These rules mean that in Go files a build constraint must appear before the package clause.
To distinguish build constraints from package documentation, a build constraint should be followed by a blank line.
There was a problem hiding this comment.
good find. gofmt added the new syntax automatically but didn't leave the empty line.
The gofmt command will add an equivalent //go:build constraint when encountering the older syntax.
I removed the old syntax
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
davis-haba
pushed a commit
to davis-haba/gatekeeper
that referenced
this pull request
Mar 7, 2023
davis-haba
pushed a commit
to davis-haba/gatekeeper
that referenced
this pull request
Mar 8, 2023
This was referenced Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sertac Ozercan sozercan@gmail.com
What this PR does / why we need it:
This was accidentally removed in #2541.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: