Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up repeated package import #2579

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

Fish-pro
Copy link
Contributor

Signed-off-by: Zechun Chen zechun.chen@daocloud.io

What this PR does / why we need it:

Clean up repeated package import

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

Signed-off-by: Zechun Chen <zechun.chen@daocloud.io>
@codecov-commenter
Copy link

Codecov Report

Base: 53.58% // Head: 53.56% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (65459a7) compared to base (0f2c8ea).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2579      +/-   ##
==========================================
- Coverage   53.58%   53.56%   -0.02%     
==========================================
  Files         120      120              
  Lines       10634    10634              
==========================================
- Hits         5698     5696       -2     
- Misses       4502     4504       +2     
  Partials      434      434              
Flag Coverage Δ
unittests 53.56% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onstrainttemplate/constrainttemplate_controller.go 56.93% <0.00%> (-3.12%) ⬇️
pkg/readiness/object_tracker.go 83.98% <0.00%> (+1.06%) ⬆️
pkg/watch/replay.go 81.25% <0.00%> (+2.27%) ⬆️
pkg/readiness/list.go 91.17% <0.00%> (+11.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan sozercan merged commit 0761889 into open-policy-agent:master Feb 14, 2023
davis-haba pushed a commit to davis-haba/gatekeeper that referenced this pull request Mar 7, 2023
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
davis-haba pushed a commit to davis-haba/gatekeeper that referenced this pull request Mar 8, 2023
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants