fix(helm): switch to curl as ENTRYPOINT for probeWebhook #2632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasmckay
force-pushed
the
curl-entrypoint
branch
from
f6f3e74
to
6ee6c37
Compare
sozercan
reviewed
Mar 20, 2023
sozercan
reviewed
Mar 20, 2023
Signed-off-by: Tom McKay <thomasmckay@redhat.com>
thomasmckay
force-pushed
the
curl-entrypoint
branch
from
6ee6c37
to
9f6da04
Compare
ritazh
approved these changes
Mar 24, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2632 +/- ##
==========================================
- Coverage 53.10% 53.07% -0.04%
==========================================
Files 120 120
Lines 10569 10569
==========================================
- Hits 5613 5609 -4
- Misses 4518 4521 +3
- Partials 438 439 +1
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
davis-haba
pushed a commit
to davis-haba/gatekeeper
that referenced
this pull request
Mar 31, 2023
…-agent#2632) Signed-off-by: Tom McKay <thomasmckay@redhat.com> Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
salaxander
pushed a commit
to salaxander/gatekeeper
that referenced
this pull request
Apr 5, 2023
…-agent#2632) Signed-off-by: Tom McKay <thomasmckay@redhat.com> Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Xander Grzywinski <xandergr@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Related to #2207, switching to use
commandto override/specify ENTRYPOINT will allow more flexibility in image choices that havecurlavailable.