feat: add support for exempt namespace suffix #2636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsmythe
reviewed
Mar 24, 2023
charts/gatekeeper/templates/gatekeeper-controller-manager-deployment.yaml
Outdated
Show resolved
Hide resolved
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2636 +/- ##
==========================================
+ Coverage 53.05% 53.24% +0.19%
==========================================
Files 120 120
Lines 10587 10594 +7
==========================================
+ Hits 5617 5641 +24
+ Misses 4530 4518 -12
+ Partials 440 435 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ritazh
reviewed
Mar 24, 2023
VirrageS
force-pushed
the
januszm-add-suffix-support
branch
from
16522d9
to
e4bc988
Compare
maxsmythe
approved these changes
Mar 24, 2023
VirrageS
force-pushed
the
januszm-add-suffix-support
branch
from
dbf0197
to
7f9a37b
Compare
Signed-off-by: Janusz Marcinkiewicz <januszm@nvidia.com>
VirrageS
force-pushed
the
januszm-add-suffix-support
branch
from
79ea2c1
to
8c1139a
Compare
|
I had to fix one more thing in manifests, should be good to test now. |
davis-haba
pushed a commit
to davis-haba/gatekeeper
that referenced
this pull request
Mar 31, 2023
Signed-off-by: Janusz Marcinkiewicz <januszm@nvidia.com>
salaxander
pushed a commit
to salaxander/gatekeeper
that referenced
this pull request
Apr 5, 2023
Signed-off-by: Janusz Marcinkiewicz <januszm@nvidia.com> Signed-off-by: Xander Grzywinski <xandergr@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This patch is to add support for exempt namespace suffixes. It is sometimes convenient to use suffix rather than prefix. This is especially useful when namespace is in form
<tenant>-<suffix>in which case we would like to exempt certain namespaces for all tenants. This feature is backward compatible.Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged): NoneSpecial notes for your reviewer: None