Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update applyTo description to mention AssignImage #2648

Merged
merged 5 commits into from Mar 31, 2023

Conversation

davis-haba
Copy link
Contributor

update a mention of applyTo to call out that applyTo is a required field for AssignImage

update a mention of `applyTo` to callout that it is a required field for `AssignImage`

Signed-off-by: Davis Haba <52938648+davis-haba@users.noreply.github.com>
website/docs/mutation.md Outdated Show resolved Hide resolved
Signed-off-by: Davis Haba <52938648+davis-haba@users.noreply.github.com>
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.04 🎉

Comparison is base (c04b2ed) 53.29% compared to head (7efe6de) 53.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2648      +/-   ##
==========================================
+ Coverage   53.29%   53.34%   +0.04%     
==========================================
  Files         120      120              
  Lines       10594    10594              
==========================================
+ Hits         5646     5651       +5     
+ Misses       4513     4510       -3     
+ Partials      435      433       -2     
Flag Coverage Δ
unittests 53.34% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

website/docs/mutation.md Outdated Show resolved Hide resolved
davis-haba and others added 2 commits March 30, 2023 15:12
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
Signed-off-by: Davis Haba <52938648+davis-haba@users.noreply.github.com>
Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxsmythe maxsmythe merged commit 9e65349 into master Mar 31, 2023
12 checks passed
salaxander pushed a commit to salaxander/gatekeeper that referenced this pull request Apr 5, 2023
…agent#2648)

Signed-off-by: Davis Haba <52938648+davis-haba@users.noreply.github.com>
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
Signed-off-by: Xander Grzywinski <xandergr@microsoft.com>
@sozercan sozercan deleted the davis-haba-patch-1 branch April 20, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants