New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update applyTo description to mention AssignImage #2648
Conversation
update a mention of `applyTo` to callout that it is a required field for `AssignImage` Signed-off-by: Davis Haba <52938648+davis-haba@users.noreply.github.com>
Signed-off-by: Davis Haba <52938648+davis-haba@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2648 +/- ##
==========================================
+ Coverage 53.29% 53.34% +0.04%
==========================================
Files 120 120
Lines 10594 10594
==========================================
+ Hits 5646 5651 +5
+ Misses 4513 4510 -3
+ Partials 435 433 -2
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Davis Haba <52938648+davis-haba@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…agent#2648) Signed-off-by: Davis Haba <52938648+davis-haba@users.noreply.github.com> Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com> Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Xander Grzywinski <xandergr@microsoft.com>
update a mention of
applyTo
to call out thatapplyTo
is a required field forAssignImage