Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate gator version #2743

Merged
merged 4 commits into from
May 10, 2023

Conversation

sozercan
Copy link
Member

@sozercan sozercan commented May 6, 2023

What this PR does / why we need it:

  • Fixes an extra "gator version" in "gator --version"

Before:

$ gator --version
gator version
Gator version: 3.12.0 ...

Now:

$ gator --version
gator version v3.12.0 ...
  • Adds top level "gator version" with ascii art with a font called alligator

image

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.12 ⚠️

Comparison is base (bd89540) 53.19% compared to head (8b5bb60) 53.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2743      +/-   ##
==========================================
- Coverage   53.19%   53.08%   -0.12%     
==========================================
  Files         126      126              
  Lines       11294    11294              
==========================================
- Hits         6008     5995      -13     
- Misses       4813     4822       +9     
- Partials      473      477       +4     
Flag Coverage Δ
unittests 53.08% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/gator/test/test.go 31.42% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

cmd/gator/utils/utils.go Outdated Show resolved Hide resolved
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan sozercan merged commit f6a200a into open-policy-agent:master May 10, 2023
14 checks passed
@sozercan sozercan deleted the fix-gator-version branch May 10, 2023 04:40
anlandu pushed a commit to anlandu/gatekeeper that referenced this pull request May 19, 2023
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Anlan Du <adu47249@gmail.com>
@ritazh ritazh added this to the v3.13.0 milestone Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants