New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: activate stats when flag is on in audit, webhook #2749
feat: activate stats when flag is on in audit, webhook #2749
Conversation
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2749 +/- ##
==========================================
+ Coverage 53.17% 53.21% +0.03%
==========================================
Files 126 126
Lines 11294 11295 +1
==========================================
+ Hits 6006 6011 +5
+ Misses 4814 4812 -2
+ Partials 474 472 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, adding an event_type
tag/value to the log output could also make these lines more filterable.
@maxsmythe there is an event type on the webhook |
…gent#2749) Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com> Co-authored-by: Max Smythe <smythe@google.com> Signed-off-by: Anlan Du <adu47249@gmail.com>
We merged #2686 (yay! 😀 ) but forgot to actually "activate" the driver options when the flags are true. 🤦🏼
This PR leverages the flags to pass in as driver opts for stats gathering.
Here's what the stats look like: