fix: Pkg Wildcard Validation to allow the ':' character #2797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mitsuwa
changed the title
Signed-off-by: Bryan Nobuhara <bryan.nobuhara@coinbase.com>
|
Please take a look when you have time @maxsmythe @acpana |
maxsmythe
approved these changes
May 30, 2023
Hy3n4
pushed a commit
to Hy3n4/gatekeeper
that referenced
this pull request
Jun 30, 2023
…agent#2797) Signed-off-by: Bryan Nobuhara <bryan.nobuhara@coinbase.com> Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com> Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Update pkg wildcard validation to allow for the
:character, as this character is common for Cluster named rbac objects, such asClusterRoleor namespaced objects likeRoles.Note that this does not allow for the
:to be the first or last characters in the NameWhich issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes # #2780
Special notes for your reviewer:
As mentioned in the issue comment. I updated the pkg/util/wildcard.go file and ran
make manifestsI then was able to run
make docker-buildwithout issue, and when I used the gatekeepr image that was built with the manifests generated viamake manifests. I no longer receive the errorTesting the Regex - link to detailed regex explanation with examples