Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Graduate ExpansionTemplate CRD to beta #2857

Merged
merged 10 commits into from Jul 7, 2023

Conversation

davis-haba
Copy link
Contributor

Upgrade ExpansionTemplate CRD to beta, and enable the workload expansion feature by default.

Signed-off-by: davis-haba <davishaba@google.com>
Signed-off-by: davis-haba <davishaba@google.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: +0.06 🎉

Comparison is base (1878de1) 53.49% compared to head (ade1218) 53.56%.

❗ Current head ade1218 differs from pull request most recent head 799c12b. Consider uploading reports for the commit 799c12b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2857      +/-   ##
==========================================
+ Coverage   53.49%   53.56%   +0.06%     
==========================================
  Files         133      133              
  Lines       11536    11536              
==========================================
+ Hits         6171     6179       +8     
+ Misses       4887     4880       -7     
+ Partials      478      477       -1     
Flag Coverage Δ
unittests 53.56% <80.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/expansion/expansion_controller.go 52.29% <75.00%> (ø)
pkg/expansion/system.go 72.04% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: davis-haba <davishaba@google.com>
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 note.

Also one other thought: do we want to change the controller to read v1beta1 expansion templates? Operationally it doesn't make a difference, but might avoid a surprise if we deprecate alpha (which is not a thing we've ever done).

I don't think I care either way.

apis/expansion/v1alpha1/expansiontemplate_types.go Outdated Show resolved Hide resolved
website/docs/expansion.md Outdated Show resolved Hide resolved
website/docs/expansion.md Outdated Show resolved Hide resolved
davis-haba and others added 4 commits July 6, 2023 14:27
Signed-off-by: davis-haba <davishaba@google.com>
Signed-off-by: davis-haba <davishaba@google.com>
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
Signed-off-by: Davis Haba <52938648+davis-haba@users.noreply.github.com>
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
Signed-off-by: Davis Haba <52938648+davis-haba@users.noreply.github.com>
@davis-haba
Copy link
Contributor Author

1 note.

Also one other thought: do we want to change the controller to read v1beta1 expansion templates? Operationally it doesn't make a difference, but might avoid a surprise if we deprecate alpha (which is not a thing we've ever done).

I don't think I care either way.

@maxsmythe I updated the expansion controllers to read v1beta1

Signed-off-by: davis-haba <davishaba@google.com>
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritazh ritazh merged commit 9a90aad into open-policy-agent:master Jul 7, 2023
16 checks passed
@ritazh ritazh added this to the v3.13.0 milestone Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants