New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Graduate ExpansionTemplate CRD to beta #2857
Conversation
Signed-off-by: davis-haba <davishaba@google.com>
Signed-off-by: davis-haba <davishaba@google.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2857 +/- ##
==========================================
+ Coverage 53.49% 53.56% +0.06%
==========================================
Files 133 133
Lines 11536 11536
==========================================
+ Hits 6171 6179 +8
+ Misses 4887 4880 -7
+ Partials 478 477 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: davis-haba <davishaba@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 note.
Also one other thought: do we want to change the controller to read v1beta1 expansion templates? Operationally it doesn't make a difference, but might avoid a surprise if we deprecate alpha (which is not a thing we've ever done).
I don't think I care either way.
Signed-off-by: davis-haba <davishaba@google.com>
Signed-off-by: davis-haba <davishaba@google.com>
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Davis Haba <52938648+davis-haba@users.noreply.github.com>
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Davis Haba <52938648+davis-haba@users.noreply.github.com>
@maxsmythe I updated the expansion controllers to read |
Signed-off-by: davis-haba <davishaba@google.com>
a64260b
to
0002b76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Upgrade ExpansionTemplate CRD to beta, and enable the workload expansion feature by default.