New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: helm probe webhook retry logic #2873
Conversation
Signed-off-by: Eshaan Mathur <37758843+eshaanm25@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for raising the PR!
cmd/build/helmify/static/templates/probe-webhook-post-install.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Eshaan Mathur <37758843+eshaanm25@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2873 +/- ##
==========================================
+ Coverage 53.53% 53.61% +0.07%
==========================================
Files 133 133
Lines 11545 11545
==========================================
+ Hits 6181 6190 +9
+ Misses 4887 4880 -7
+ Partials 477 475 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Eshaan Mathur <37758843+eshaanm25@users.noreply.github.com> Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Xander Grzywinski <xandergrzyw@gmail.com>
What this PR does / why we need it:
--retry-connrefused
flag to the curl command in the Gatekeeper post-install webhookWhich issue(s) this PR fixes:
Fixes #2872