-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: helm-chart: controller-manager wh name flags #2879
Conversation
Signed-off-by: Ugur <ugurozturk918@gmail.com>
@ugur99 thanks for the PR! Gatekeeper helm chart is autogenerated and these changes will be clobbered in the next release. Please refer to Contributing to Helm Chart for modifying the Helm chart. |
Signed-off-by: Ugur Ozturk <ugurozturk918@gmail.com>
Thank you for the quick reply @sozercan! I hope it's now fixed and compatible with the contrib. document 🤞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Someone correct me if I am wrong but I think we should also update the name of the mutating webhook in the rbac role.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's already a template for the cluster role parametrization.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2879 +/- ##
==========================================
- Coverage 53.13% 53.10% -0.04%
==========================================
Files 135 135
Lines 11790 11790
==========================================
- Hits 6265 6261 -4
- Misses 5041 5044 +3
- Partials 484 485 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the fix! 🎉
Hello team! I think this fix has not been released yet, do you have any ideas when or in which version it will be released? |
Signed-off-by: Ugur Can Ozturk ugurozturk918@gmail.com
What this PR does / why we need it:
This PR fixes missing flags problems of the gatekeeper-controller-manager
Which issue(s) this PR fixes
Fixes #2878