Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding cel demo #2908

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Conversation

JaydipGabani
Copy link
Contributor

What this PR does / why we need it: Adding demo gif for cel

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

@ritazh
Copy link
Member

ritazh commented Jul 28, 2023

Thanks for adding this @JaydipGabani
I just noticed we don't have any docs for Integration with k8s Validating Admission Policy. Can you pls add some docs and how to use it with the experimental-enable-k8s-native-validation flag?

For the recorded demo, might be useful to also show the actual code in the constraint template as that is the big difference, otherwise the experience is pretty much the same (as it's intended).

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

LGTM

@JaydipGabani
Copy link
Contributor Author

I just noticed we don't have any docs for Integration with k8s Validating Admission Policy. Can you pls add some docs and how to use it with the experimental-enable-k8s-native-validation flag?

@ritazh do we want it on website or this README works for now?

@ritazh
Copy link
Member

ritazh commented Jul 31, 2023

I just noticed we don't have any docs for Integration with k8s Validating Admission Policy. Can you pls add some docs and how to use it with the experimental-enable-k8s-native-validation flag?

@ritazh do we want it on website or this README works for now?

Having it on the website will make it easier for discoverability. We should make sure to state its current status. @maxsmythe in your opinion, is this "pre-alpha" or "alpha".

Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
@maxsmythe
Copy link
Contributor

It's a prototype. We know that the syntax will change.

@ritazh
Copy link
Member

ritazh commented Aug 2, 2023

It's a prototype. We know that the syntax will change.

Pre-alpha then

@sozercan
Copy link
Member

sozercan commented Aug 9, 2023

@ritazh are you okay to merge this pr? for other items, we can open seperate issues/prs?

@ritazh
Copy link
Member

ritazh commented Aug 10, 2023

@ritazh are you okay to merge this pr? for other items, we can open seperate issues/prs?

SGTM I see the demo has been updated. doc PR can be a follow up.

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritazh ritazh merged commit f7e89bd into open-policy-agent:master Aug 10, 2023
3 checks passed
@JaydipGabani JaydipGabani deleted the celdemo branch August 10, 2023 20:25
salaxander pushed a commit to salaxander/gatekeeper that referenced this pull request Sep 13, 2023
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants