-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adding cel demo #2908
chore: adding cel demo #2908
Conversation
Thanks for adding this @JaydipGabani For the recorded demo, might be useful to also show the actual code in the constraint template as that is the big difference, otherwise the experience is pretty much the same (as it's intended). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
LGTM
@ritazh do we want it on website or this README works for now? |
Having it on the website will make it easier for discoverability. We should make sure to state its current status. @maxsmythe in your opinion, is this "pre-alpha" or "alpha". |
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
It's a prototype. We know that the syntax will change. |
Pre-alpha then |
@ritazh are you okay to merge this pr? for other items, we can open seperate issues/prs? |
SGTM I see the demo has been updated. doc PR can be a follow up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
What this PR does / why we need it: Adding demo gif for cel
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: