Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use buildinfo to get opa and frameworks version #2950

Merged
merged 2 commits into from
Aug 12, 2023

Conversation

sozercan
Copy link
Member

@sozercan sozercan commented Aug 11, 2023

What this PR does / why we need it:

  • Uses buildinfo to bake in opa and frameworks version so these will be visible in gator installed from homebrew. Unfortunately, we cannot do this for tag since Go doesn't support that (since tags are mutable?), so we have to keep LDFLAGS for version.
  • Printing OPA version inside manager too since we are getting questions about this
  • Fixes version bug that we missed to add /v3

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #2534

Special notes for your reviewer:

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan
Copy link
Member Author

Homebrew/homebrew-core#139343 fixes the go mod change on brew side

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.09% ⚠️

Comparison is base (cf867d1) 53.14% compared to head (1fe0d79) 53.05%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2950      +/-   ##
==========================================
- Coverage   53.14%   53.05%   -0.09%     
==========================================
  Files         135      135              
  Lines       11806    11806              
==========================================
- Hits         6274     6264      -10     
- Misses       5047     5054       +7     
- Partials      485      488       +3     
Flag Coverage Δ
unittests 53.05% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan sozercan merged commit 5e0e0c0 into open-policy-agent:master Aug 12, 2023
15 checks passed
@sozercan sozercan deleted the fix-2534 branch August 12, 2023 20:37
salaxander pushed a commit to salaxander/gatekeeper that referenced this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gator version from homebrew doesn't report OPA and frameworks version
4 participants