feat: Upgrade constraint framework to add new K8s Native Validation driver schema #2951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsmythe
changed the title
…schema Signed-off-by: Max Smythe <smythe@google.com>
maxsmythe
force-pushed
the
use-new-vap-driver
branch
from
227a855
to
b24909e
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2951 +/- ##
==========================================
- Coverage 53.17% 53.09% -0.09%
==========================================
Files 135 135
Lines 11806 11806
==========================================
- Hits 6278 6268 -10
- Misses 5044 5052 +8
- Partials 484 486 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ritazh
reviewed
Aug 15, 2023
| messageExpression: '"missing required label, requires all of: " + params.spec.parameters.labels.map(entry, entry.key).join(", ")' | ||
| - expression: "!params.spec.parameters.labels.exists(entry, has(object.metadata.labels) && entry.key in object.metadata.labels && !string(object.metadata.labels[entry.key]).matches(string(entry.allowedRegex)))" | ||
| message: "regex mismatch" | ||
| validations: |
There was a problem hiding this comment.
This is going to break with 3.13.0 release right? How about updating the readme in this folder to build from head or use openpolicyagent/gatekeeper:dev?
Signed-off-by: Max Smythe <smythe@google.com>
salaxander
pushed a commit
to salaxander/gatekeeper
that referenced
this pull request
Sep 13, 2023
…river schema (open-policy-agent#2951) Signed-off-by: Max Smythe <smythe@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the schema for the K8sNativeValidation driver to match the design doc in https://docs.google.com/document/d/1FgwMQHEzKaBMQzsbWkBfuUiNcALOKyJJ3_WkgP-L7mo/edit
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: